[webkit-reviews] review granted: [Bug 196162] Refactor clz/ctz and fix getLSBSet. : [Attachment 365770] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 16:13:31 PDT 2019

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 196162: Refactor clz/ctz and fix getLSBSet.

Attachment 365770: Patch


--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 365770
  --> https://bugs.webkit.org/attachment.cgi?id=365770

View in context: https://bugs.webkit.org/attachment.cgi?id=365770&action=review

> Source/WTF/ChangeLog:12
> +	   numeric type. Since these methods work on any type we don't need
> +	   to have an, incorrect, implementation of getLSBSet. This patch
> +	   also adds getMSBSet as there may be users who want that in the
> +	   future.

I'd explain a bit more here.
- The old implementation of getLSBSet was really getMSBSet

> Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:435

nit: I think writing out these numbers in binary would make it easier to

More information about the webkit-reviews mailing list