[webkit-reviews] review granted: [Bug 196156] Include the CFNetworking task UUID to the NSError when a resource-load fails : [Attachment 365753] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 14:02:50 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 196156: Include the CFNetworking task UUID to the NSError when a
resource-load fails
https://bugs.webkit.org/show_bug.cgi?id=196156

Attachment 365753: Patch

https://bugs.webkit.org/attachment.cgi?id=365753&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 365753
  --> https://bugs.webkit.org/attachment.cgi?id=365753
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365753&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:611
> +	   newUserInfo[@"networkTaskID"] = [task description];

Maybe we should have "Description" in the key instead of "ID"


More information about the webkit-reviews mailing list