[webkit-reviews] review granted: [Bug 193724] Flaky AVEncoderBitRateKey symbol not found crash on imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html : [Attachment 365759] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 193724: Flaky AVEncoderBitRateKey symbol not found crash on
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.h
tml
https://bugs.webkit.org/show_bug.cgi?id=193724

Attachment 365759: Patch

https://bugs.webkit.org/attachment.cgi?id=365759&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 365759
  --> https://bugs.webkit.org/attachment.cgi?id=365759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365759&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
86
> +#define AVEncoderBitRateKey myAVEncoderBitRateKey()
> +#define AVFormatIDKey myAVFormatIDKey()
> +#define AVNumberOfChannelsKey myAVNumberOfChannelsKey()
> +#define AVSampleRateKey myAVSampleRateKey()

"my" as a prefix isn't useful. Could these be changed to "get*WithFallback()"?