[webkit-reviews] review granted: [Bug 196149] Implement WebProcess freezer opt-in completely on WebContent process side : [Attachment 365738] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 196149: Implement WebProcess freezer opt-in completely on WebContent
process side
https://bugs.webkit.org/show_bug.cgi?id=196149

Attachment 365738: Patch

https://bugs.webkit.org/attachment.cgi?id=365738&action=review




--- Comment #12 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 365738
  --> https://bugs.webkit.org/attachment.cgi?id=365738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365738&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:693
> +    switch (m_processType) {
> +    case ProcessType::Inspector:
> +    case ProcessType::ServiceWorker:
> +    case ProcessType::PrewarmedWebContent:
> +    case ProcessType::CachedWebContent:
> +	   return false;
> +    case ProcessType::WebContent:
> +	   break;
> +    }

I like how explicitly this is about prewarmed/cached. 👍