[webkit-reviews] review denied: [Bug 195996] Geolocation request not complete when watch request was started in a different web process : [Attachment 365704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 09:53:45 PDT 2019


Alex Christensen <achristensen at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 195996: Geolocation request not complete when watch request was started in
a different web process
https://bugs.webkit.org/show_bug.cgi?id=195996

Attachment 365704: Patch

https://bugs.webkit.org/attachment.cgi?id=365704&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 365704
  --> https://bugs.webkit.org/attachment.cgi?id=365704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365704&action=review

>> Source/WebKit/Shared/WebProcessCreationParameters.cpp:170
>> +	encoder << lastGeolocationPosition;
> 
> I do not think we should do this.

I agree.


More information about the webkit-reviews mailing list