[webkit-reviews] review granted: [Bug 196119] REGRESSION (r243094): ePub files do not render or open in Books : [Attachment 365661] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 09:04:55 PDT 2019


Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 196119: REGRESSION (r243094): ePub files do not render or open in Books
https://bugs.webkit.org/show_bug.cgi?id=196119

Attachment 365661: Patch

https://bugs.webkit.org/attachment.cgi?id=365661&action=review




--- Comment #7 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 365661
  --> https://bugs.webkit.org/attachment.cgi?id=365661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365661&action=review

Any testing possible?

> Source/WebKit/ChangeLog:9
> +	   Do not delay the WebProcess launch until a load when contructing a
Web view and the client

"Web view" is bizarre.

WebView?

> Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm:219
> +    // If the client can observer when the connection to the WebProcess
injected bundle is established, then we cannot

can observe


More information about the webkit-reviews mailing list