[webkit-reviews] review granted: [Bug 196084] Remove the SVG tear off objects for SVGNumber, SVGNumberList and SVGAnimatedNumberList : [Attachment 365650] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 17:38:26 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 196084: Remove the SVG tear off objects for SVGNumber, SVGNumberList and
SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=196084

Attachment 365650: Patch

https://bugs.webkit.org/attachment.cgi?id=365650&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 365650
  --> https://bugs.webkit.org/attachment.cgi?id=365650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365650&action=review

> Source/WebCore/svg/properties/SVGAnimationAdditiveListFunctionImpl.h:58
> +	   const Vector<Ref<SVGNumber>>& fromItems = m_animationMode ==
AnimationMode::To ? animated->items() : m_from->items();
> +	   const Vector<Ref<SVGNumber>>& toItems = m_to->items();
> +	   const Vector<Ref<SVGNumber>>& toAtEndOfDurationItems =
toAtEndOfDuration()->items();

auto?


More information about the webkit-reviews mailing list