[webkit-reviews] review granted: [Bug 196120] Crash at IDBDatabaseInfo::infoForExistingObjectStore and IDBDatabaseInfo::infoForExistingObjectStore : [Attachment 365653] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 196120: Crash at IDBDatabaseInfo::infoForExistingObjectStore and
IDBDatabaseInfo::infoForExistingObjectStore
https://bugs.webkit.org/show_bug.cgi?id=196120

Attachment 365653: Patch

https://bugs.webkit.org/attachment.cgi?id=365653&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 365653
  --> https://bugs.webkit.org/attachment.cgi?id=365653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365653&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1299
> +	   RELEASE_LOG(IndexedDB, "%p -
SQLiteIDBBackingStore::clearObjectStore: m_databaseInfo is null for database
%s", this, m_identifier.databaseName().utf8().data());

Maybe use RELEASE_LOG_ERROR? I don't think we should log the database name
though...
That doesn't sound right from privacy perspective.

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1003
> +	   RELEASE_LOG(IndexedDB, "%p - UniqueIDBDatabase::performCreateIndex:
m_backingStore is null for database %s", this,
m_identifier.databaseName().utf8().data());

Ditto.

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1207
> +	   RELEASE_LOG(IndexedDB, "%p - UniqueIDBDatabase::performPutOrAdd:
m_backingStore is null for database %s", this,
m_identifier.databaseName().utf8().data());

Ditto.