[webkit-reviews] review granted: [Bug 196116] Remove an invalid assertion in DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined(). : [Attachment 365639] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 196116: Remove an invalid assertion in
DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined().
https://bugs.webkit.org/show_bug.cgi?id=196116

Attachment 365639: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=365639&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 365639
  --> https://bugs.webkit.org/attachment.cgi?id=365639
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=365639&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   The DFG backend should not make assumptions about what optimizations
the front end
> +	   will or will not do.  The assertion asserts that the operand cannot
be known to be

You're right - the DFG is making a back assumption here because optimizations
should be optional.