[webkit-reviews] review granted: [Bug 196107] [Web GPU] Prototype compute pipeline with MSL : [Attachment 365635] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 196107: [Web GPU] Prototype compute pipeline with MSL
https://bugs.webkit.org/show_bug.cgi?id=196107

Attachment 365635: Patch

https://bugs.webkit.org/attachment.cgi?id=365635&action=review




--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 365635
  --> https://bugs.webkit.org/attachment.cgi?id=365635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365635&action=review

> Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:69
> +    virtual void setVertexBuffer(const MTLBuffer *, unsigned, unsigned) { }
> +    virtual void setFragmentBuffer(const MTLBuffer *, unsigned, unsigned) {
}
> +    // Compute.
> +    virtual void setComputeBuffer(const MTLBuffer *, unsigned, unsigned) { }

https://github.com/gpuweb/gpuweb/commit/678d728f20730b03134509c75aaa4f197a3cb8d
f