[webkit-reviews] review granted: [Bug 196099] Fix key path extraction code in IndexedDB to check own property : [Attachment 365621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 15:29:29 PDT 2019

Ryosuke Niwa <rniwa at webkit.org> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 196099: Fix key path extraction code in IndexedDB to check own property

Attachment 365621: Patch


--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 365621
  --> https://bugs.webkit.org/attachment.cgi?id=365621

View in context: https://bugs.webkit.org/attachment.cgi?id=365621&action=review

> Source/WebCore/ChangeLog:3
> +	   Fix three IDB WPT tests

Let's update the bug title as I renamed. This doesn't tell us what we're doing
at all.
You can mention that you're fixing a few other bugs as well.

> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:70
> +    if (obj->inherits<JSArray>(vm) && (keyPathElement == "length")) {

I think we need to use isArray in ArrayConstructor.h instead.
No parenthesis is needed around keyPathElement ==.

> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:71
> +	   result = jsNumber(asArray(object)->length());

And then run [[GET]] here.

> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:75
> +	   result = obj->get(&exec, identifier);

I don't think we should be running getter here.
To something like jsBlob.wrapped()->size()

> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:79
> +	   result = obj->get(&exec, identifier);


More information about the webkit-reviews mailing list