[webkit-reviews] review granted: [Bug 196051] [ContentChangeObserver] Start tracking implicit transitions at touchStart : [Attachment 365549] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 11:06:46 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 196051: [ContentChangeObserver] Start tracking implicit transitions at
touchStart
https://bugs.webkit.org/show_bug.cgi?id=196051

Attachment 365549: Patch

https://bugs.webkit.org/attachment.cgi?id=365549&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 365549
  --> https://bugs.webkit.org/attachment.cgi?id=365549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365549&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:357
>	   }
> +	   // It's way too early to notify the client.

Remove.

> Source/WebCore/page/ios/ContentChangeObserver.h:173
> +	   CancelledTransition,

Canceled?


More information about the webkit-reviews mailing list