[webkit-reviews] review granted: [Bug 196021] [iOS] Inline -_ensureFormAccessoryView into -formAccessoryView and have -_updateAccessory ensure we have a form accessory : [Attachment 365374] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 21 10:47:16 PDT 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 196021: [iOS] Inline -_ensureFormAccessoryView into -formAccessoryView and
have -_updateAccessory ensure we have a form accessory
https://bugs.webkit.org/show_bug.cgi?id=196021
Attachment 365374: Patch
https://bugs.webkit.org/attachment.cgi?id=365374&action=review
--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 365374
--> https://bugs.webkit.org/attachment.cgi?id=365374
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=365374&action=review
> Source/WebKit/ChangeLog:9
> + Every caller of -_ensureFormAccessoryView, except
-formAccessoryView, immediately the call with
> + -_updateAccessory. Let's just have -_updateAccessory ensure we have
a form accessory view and
Nit - "immediately the call with"
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3784
> + [self formAccessoryView]; // Creates one if needed.
Nit - we can also do something like:
UIWebFormAccessory *accessoryView = [self formAccessoryView];
...and then just use the accessoryView variable below, instead of
_formAccessoryView. I think we wouldn't need the comment if we did this.
More information about the webkit-reviews
mailing list