[webkit-reviews] review denied: [Bug 196072] [JSC] Fix build after r243232 on unsupported 64bit architectures : [Attachment 365529] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Tomas Popela <tpopela at redhat.com>'s
request for review:
Bug 196072: [JSC] Fix build after r243232 on unsupported 64bit architectures
https://bugs.webkit.org/show_bug.cgi?id=196072

Attachment 365529: Patch

https://bugs.webkit.org/attachment.cgi?id=365529&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 365529
  --> https://bugs.webkit.org/attachment.cgi?id=365529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365529&action=review

Also please undef your define at the bottom of the header

> Source/JavaScriptCore/bytecode/CodeOrigin.h:34
> +#define USE_COMPRESSED_CODE_ORIGIN CPU(ARM64) || CPU(X86_64)

We can only opt in (ARM64 && ADDRESS64)
We don’t want compression scheme for ARM64_32