[webkit-reviews] review granted: [Bug 196058] Add an internal feature flag to disable the -webkit-overflow-scrolling CSS property : [Attachment 365550] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 21 09:17:22 PDT 2019
Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 196058: Add an internal feature flag to disable the
-webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=196058
Attachment 365550: Patch
https://bugs.webkit.org/attachment.cgi?id=365550&action=review
--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 365550
--> https://bugs.webkit.org/attachment.cgi?id=365550
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=365550&action=review
r=me with change to const CSSParserContext&.
> Source/WebCore/css/parser/CSSParserFastPaths.cpp:523
> +bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID
propertyId, CSSValueID valueID, CSSParserMode parserMode, const
CSSParserContext* context)
How would the caller know when to provide this context? Please make it a
reference and like everywhere else it is used.
> Source/WebCore/css/parser/CSSParserFastPaths.cpp:810
> + WTFLogAlways("Parsing CSSPropertyWebkitOverflowScrolling; enabled
%d", context && context->legacyOverflowScrollingTouchEnabled);
Please don't leave spammy logging in.
More information about the webkit-reviews
mailing list