[webkit-reviews] review granted: [Bug 195867] [MSE][GStreamer] Don't construct segments on PlaybackPipeline::flush : [Attachment 365538] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 09:07:32 PDT 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted  review:
Bug 195867: [MSE][GStreamer] Don't construct segments on
PlaybackPipeline::flush
https://bugs.webkit.org/show_bug.cgi?id=195867

Attachment 365538: Patch

https://bugs.webkit.org/attachment.cgi?id=365538&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 365538
  --> https://bugs.webkit.org/attachment.cgi?id=365538
Patch

(In reply to Xabier Rodríguez Calvar from comment #7)
> Comment on attachment 365538 [details]
> Patch
> 
> The directory of imported test is only for imported tests. We shouldn't add
> a test there if it didn't land on the WPT repo yet. We need to move it to
> our LayoutTests/media/media-source/ while we wait for the other to land.
> 
> One this patch is landed, we create another bug to keep track of the WPT
> pull request.

Forget about this, everything is ok.


More information about the webkit-reviews mailing list