[webkit-reviews] review granted: [Bug 178489] Web Inspector: Styles Redesign: Editing selector should not hide the rule : [Attachment 365415] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 178489: Web Inspector: Styles Redesign: Editing selector should not hide
the rule
https://bugs.webkit.org/show_bug.cgi?id=178489

Attachment 365415: Patch

https://bugs.webkit.org/attachment.cgi?id=365415&action=review




--- Comment #30 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 365415
  --> https://bugs.webkit.org/attachment.cgi?id=365415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365415&action=review

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:80
> +	    // Try to use the node to find the frame which has the correct
resource first.

Bad indentation.

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:89
> +	    // If that didn't find the resource, then search all frames.

Ditto.

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
366
> +	   section.__showingForNode = this.nodeStyles.node;
> +	   section.__index = this._sections.indexOf(section);

Should change these to symbols so they are only visible in this file.