[webkit-reviews] review granted: [Bug 196020] Add UI process WebRTC runtime logging. : [Attachment 365418] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 196020: Add UI process WebRTC runtime logging.
https://bugs.webkit.org/show_bug.cgi?id=196020

Attachment 365418: Patch

https://bugs.webkit.org/attachment.cgi?id=365418&action=review




--- Comment #15 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 365418
  --> https://bugs.webkit.org/attachment.cgi?id=365418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365418&action=review

> Source/WebCore/inspector/agents/page/PageConsoleAgent.h:46
>      virtual ~PageConsoleAgent() = default;

This default destructor is probably not needed.

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h:89
> +    const Logger& logger() const final { return m_logger.get(); }

Could be implemented as m_page.logger();
We could then remove m_logger and we would be sure to be in sync with whatever
page logger is.

> Source/WebKit/UIProcess/WebPageProxy.cpp:8931
> +	   m_logger->setEnabled(this, isAlwaysOnLoggingAllowed());

When we are changing of WebPageProxy::m_websiteDataStore, we might change of
isAlwaysOnLoggingAllowed() return value.
Maybe logger should be updated accordingly at that time.