[webkit-reviews] review granted: [Bug 196035] [iOS] Crash in WebCore::Node::renderRect : [Attachment 365416] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 20 15:47:34 PDT 2019
Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 196035: [iOS] Crash in WebCore::Node::renderRect
https://bugs.webkit.org/show_bug.cgi?id=196035
Attachment 365416: Patch
https://bugs.webkit.org/attachment.cgi?id=365416&action=review
--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 365416
--> https://bugs.webkit.org/attachment.cgi?id=365416
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=365416&action=review
> Source/WebCore/dom/Node.cpp:799
> + if (!hitRenderer && is<HTMLAreaElement>(*this)) {
You can use simply `this` here.
> Source/WebCore/dom/Node.cpp:802
> + auto* imageElement = area.imageElement();
> + if (imageElement)
if (auto* …)
More information about the webkit-reviews
mailing list