[webkit-reviews] review granted: [Bug 195987] [CSS OM] StyledElementInlineStylePropertyMap creates a Ref cycle with its owner element : [Attachment 365309] Updated the change log
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 20 13:01:45 PDT 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 195987: [CSS OM] StyledElementInlineStylePropertyMap creates a Ref cycle
with its owner element
https://bugs.webkit.org/show_bug.cgi?id=195987
Attachment 365309: Updated the change log
https://bugs.webkit.org/attachment.cgi?id=365309&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 365309
--> https://bugs.webkit.org/attachment.cgi?id=365309
Updated the change log
View in context: https://bugs.webkit.org/attachment.cgi?id=365309&action=review
> Source/WebCore/dom/Element.cpp:209
> + if (auto* map = elementRareData()->attributeStyleMap())
> + map->clearElement();
Maybe ElementRareData should have a clearElement or clearNdoe function on it
More information about the webkit-reviews
mailing list