[webkit-reviews] review denied: [Bug 195140] Move initialHTTPCookieAcceptPolicy to NetworkSession : [Attachment 363178] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 195140: Move initialHTTPCookieAcceptPolicy to NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=195140

Attachment 363178: Patch

https://bugs.webkit.org/attachment.cgi?id=363178&action=review




--- Comment #18 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 363178
  --> https://bugs.webkit.org/attachment.cgi?id=363178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363178&action=review

It is not obvious that this patch does not change behavior on Cocoa platforms. 
I think this patch should be redone in a simpler way that is clear it only
affects lib soup.

> Source/WebKit/NetworkProcess/NetworkSession.cpp:75
> +   
networkProcess.supplement<WebCookieManager>()->setHTTPCookieAcceptPolicy(m_sess
ionID, parameters.initialHTTPCookieAcceptPolicy, OptionalCallbackID());

This seems like it's in the wrong place.