[webkit-reviews] review granted: [Bug 192648] Web Inspector: Debugger: virtualize the list of variables in the Scope sidebar : [Attachment 364437] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 192648: Web Inspector: Debugger: virtualize the list of variables in the
Scope sidebar
https://bugs.webkit.org/show_bug.cgi?id=192648

Attachment 364437: Patch

https://bugs.webkit.org/attachment.cgi?id=364437&action=review




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 364437
  --> https://bugs.webkit.org/attachment.cgi?id=364437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364437&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:588
> +		   return true;

Nice. Should update the existing Array.prototype.remove tests in:
LayoutTests/inspector/unit-tests/array-utilities.html

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:452
> +	   if (this.virtualized)
> +	       this._virtualizedDebouncer.delayForFrame();

Previously we would only delayForFrame if the element was not known. Do we want
to do this always now (probably fine).