[webkit-reviews] review granted: [Bug 196018] [iOS] Group UIWebFormAccessoryDelegate-related code and tighten it up a bit : [Attachment 365368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 11:48:28 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 196018: [iOS] Group UIWebFormAccessoryDelegate-related code and tighten it
up a bit
https://bugs.webkit.org/show_bug.cgi?id=196018

Attachment 365368: Patch

https://bugs.webkit.org/attachment.cgi?id=365368&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 365368
  --> https://bugs.webkit.org/attachment.cgi?id=365368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365368&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3753
> +    _page->setFocusedElementValue(String { });

Nit - wouldn't just { } be more concise?


More information about the webkit-reviews mailing list