[webkit-reviews] review denied: [Bug 167035] Web Inspector: no way to filter out all console messages or all evaluations/results : [Attachment 362876] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 09:26:30 PDT 2019


Timothy Hatcher <timothy at apple.com> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 167035: Web Inspector: no way to filter out all console messages or all
evaluations/results
https://bugs.webkit.org/show_bug.cgi?id=167035

Attachment 362876: Patch

https://bugs.webkit.org/attachment.cgi?id=362876&action=review




--- Comment #9 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 362876
  --> https://bugs.webkit.org/attachment.cgi?id=362876
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362876&action=review

I like this, but it should be called Evaluations.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:87
> +	       new WI.ScopeBarItem(WI.LogContentView.Scopes.Prompt,
WI.UIString("Prompt"), {className: "prompt"}),

Evaluations?


More information about the webkit-reviews mailing list