[webkit-reviews] review granted: [Bug 192719] Web Inspector: Debugger: move breakpoint storage to use `WI.ObjectStore` : [Attachment 364948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 08:52:01 PDT 2019


Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 192719: Web Inspector: Debugger: move breakpoint storage to use
`WI.ObjectStore`
https://bugs.webkit.org/show_bug.cgi?id=192719

Attachment 364948: Patch

https://bugs.webkit.org/attachment.cgi?id=364948&action=review




--- Comment #12 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 364948
  --> https://bugs.webkit.org/attachment.cgi?id=364948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364948&action=review

> Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:224
> +	   type = type || WI.BreakpointAction.Type.Log;

Why do this?

> Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:292
> +    serializeOptions()

serializableOptions?


More information about the webkit-reviews mailing list