[webkit-reviews] review granted: [Bug 195993] ContentChangeObserver build error for not include Element.h : [Attachment 365328] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 02:27:02 PDT 2019


Rob Buis <rbuis at igalia.com> has granted cathiechen <cathiechen at igalia.com>'s
request for review:
Bug 195993: ContentChangeObserver build error for not include Element.h
https://bugs.webkit.org/show_bug.cgi?id=195993

Attachment 365328: Patch

https://bugs.webkit.org/attachment.cgi?id=365328&action=review




--- Comment #3 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 365328
  --> https://bugs.webkit.org/attachment.cgi?id=365328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review

ContentChangeObserver.h may need more fixes, I see Frame is used as well.
Change does not hurt though so let's go for it, with ChangeLog improvement
please.

> Source/WebCore/ChangeLog:8
> +	   ContentChangeObserver should include Element.h.

Please add some more context, i.e. how you found out there is a build error.


More information about the webkit-reviews mailing list