[webkit-reviews] review granted: [Bug 195973] Web Inspector: Debugger: lazily create the agent : [Attachment 365264] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195973: Web Inspector: Debugger: lazily create the agent
https://bugs.webkit.org/show_bug.cgi?id=195973

Attachment 365264: Patch

https://bugs.webkit.org/attachment.cgi?id=365264&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 365264
  --> https://bugs.webkit.org/attachment.cgi?id=365264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365264&action=review

> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:245
> +	   if (m_debuggerAgent) {

This should always be true. I'd drop the if check. The only path to get here
(that we expect) is through InspectorAgent::initialized meaning the agents are
alive and a frontend sent a message.

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:107
> +    for (auto* listener : copyToVector(m_listeners))
> +	   listener->debuggerWasDisabled();

Why upgrade this to a list. Do you expect to add more listeners?