[webkit-reviews] review granted: [Bug 195977] Add support for more platforms to generate-xcfilelists : [Attachment 365260] Fix the location of the 'Reviewed by' statement in the changelog.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 195977: Add support for more platforms to generate-xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=195977

Attachment 365260: Fix the location of the 'Reviewed by' statement in the
changelog.

https://bugs.webkit.org/attachment.cgi?id=365260&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 365260
  --> https://bugs.webkit.org/attachment.cgi?id=365260
Fix the location of the 'Reviewed by' statement in the changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=365260&action=review

Conditional r=me assuming that you either tested tvOS simulator code path, or
will test it and fix as necessary.

> Tools/Scripts/generate-xcfilelists:642
> +    [[ "${GX_PROVISIONAL_PLATFORM_NAME}" == "tvsimulator" ]] && { echo
"tvsimulator"; return; }

I'm not quite sure where this string goes in the end, but my guess is that it
should be appletvsimulator, not tvsimulator.