[webkit-reviews] review granted: [Bug 195906] JSC test crash: stress/dont-strength-reduce-regexp-with-compile-error.js.default : [Attachment 365254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 16:34:35 PDT 2019

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 195906: JSC test crash:

Attachment 365254: Patch


--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 365254
  --> https://bugs.webkit.org/attachment.cgi?id=365254

View in context: https://bugs.webkit.org/attachment.cgi?id=365254&action=review

r=me.  Why not also do stack checks in opCompileAlternative(), opCompileBody(),
and compile().	I think at minimum, it makes sense to do a check at the top
level compile() function.  This check will probably cover many functions that
are 1 level deeper than compile().  Anything that can recurse below that will
need additional checks.

> Source/JavaScriptCore/ChangeLog:19
> +	   This change is covered by the previously added test that is failing.

Would be nice to name the test here for reference.

More information about the webkit-reviews mailing list