[webkit-reviews] review granted: [Bug 195960] Remove the SVG property tear off objects of SVGAnimatedPreserveAspectRatio : [Attachment 365208] Patch for review

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 195960: Remove the SVG property tear off objects of
SVGAnimatedPreserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=195960

Attachment 365208: Patch for review

https://bugs.webkit.org/attachment.cgi?id=365208&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 365208
  --> https://bugs.webkit.org/attachment.cgi?id=365208
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=365208&action=review

> Source/WebCore/ChangeLog:12
> +	   -- Define SVGAnimatedPreserveAspectRatio to be
SVGAnimatedValueProperty<
> +	      SVGPreserveAspectRatio>.
> +
> +	   -- Make SVGPreserveAspectRatio be derived form SVGValueProperty<S
> +	      VGPreserveAspectRatioValue>.

Bad wrapping.

> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84
> +	   return std::unique_ptr<SVGAnimatedPreserveAspectRatioAnimator>(new
SVGAnimatedPreserveAspectRatioAnimator(attributeName, animated, animationMode,
calcMode, isAccumulated, isAdditive));

make_unique<>