[webkit-reviews] review granted: [Bug 195949] Remove the SVG property tear off objects of SVGAnimatedRect : [Attachment 365199] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 15:49:36 PDT 2019

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 195949: Remove the SVG property tear off objects of SVGAnimatedRect

Attachment 365199: Patch


--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 365199
  --> https://bugs.webkit.org/attachment.cgi?id=365199

View in context: https://bugs.webkit.org/attachment.cgi?id=365199&action=review

> Source/WebCore/ChangeLog:22
> +	   SVGAnimatedValueProperty will be responsible of:

responsible for

> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84
> +	   return std::unique_ptr<SVGAnimatedRectAnimator>(new
SVGAnimatedRectAnimator(attributeName, animated, animationMode, calcMode,
isAccumulated, isAdditive));

std::make_unique. Seeing a 'new' in the code should ring alarm bells.

More information about the webkit-reviews mailing list