[webkit-reviews] review granted: [Bug 195923] Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource : [Attachment 365203] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 195923: Resource Load Statistics (experimental): Clear non-cookie website
data for sites that have been navigated to, with link decoration, by a
prevalent resource
https://bugs.webkit.org/show_bug.cgi?id=195923

Attachment 365203: Patch

https://bugs.webkit.org/attachment.cgi?id=365203&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 365203
  --> https://bugs.webkit.org/attachment.cgi?id=365203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365203&action=review

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:1519
> +    HashMap<RegistrableDomain, WebsiteDataToRemove>
domainsToRemoveWebsiteDataFor;

If we used a struct that contained 3 Vector<RegistrableDomain> instead of the
enum, it would be more memory efficient.

> Tools/WebKitTestRunner/TestInvocation.cpp:1311
> +	   WKRetainPtr<WKStringRef> fromHostKey(AdoptWK,
WKStringCreateWithUTF8CString("FromHost"));

auto fromHostKey = adoptWK(WKStringCreateWithUTF8CString("FromHost"));