[webkit-reviews] review granted: [Bug 195920] Build cleanly with GCC 9 : [Attachment 365161] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 195920: Build cleanly with GCC 9
https://bugs.webkit.org/show_bug.cgi?id=195920

Attachment 365161: Patch

https://bugs.webkit.org/attachment.cgi?id=365161&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 365161
  --> https://bugs.webkit.org/attachment.cgi?id=365161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365161&action=review

r=me

>
Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py:234
> +	       return
reinterpret_cast<Ref<${objectType}>*>(&result)->copyRef();

Ideally, we'd find a way to write this which does not involve a copyRef(), to
maintain the same performance characteristics.

> Source/WebCore/Modules/fetch/FetchBody.cpp:246
> +	   return body.copyRef();

This seems worse, would the compiler accept:
return FetchBody { WTFMove(body) }; ?

> Source/WebCore/Modules/fetch/FetchBody.cpp:256
> +	   return body.copyRef();

ditto.

> Source/WebCore/Modules/fetch/FetchBody.cpp:277
> +	   return body.copyRef();

ditto.

> Source/WebCore/dom/ScriptDisallowedScope.h:58
> +    ScriptDisallowedScope& operator=(const ScriptDisallowedScope&)

would "= default;" work?