[webkit-reviews] review granted: [Bug 195588] Web Inspector: DOMStorage: lazily create the agent : [Attachment 364976] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195588: Web Inspector: DOMStorage: lazily create the agent
https://bugs.webkit.org/show_bug.cgi?id=195588

Attachment 364976: Patch

https://bugs.webkit.org/attachment.cgi?id=364976&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 364976
  --> https://bugs.webkit.org/attachment.cgi?id=364976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364976&action=review

r=me

> Source/WebCore/inspector/CommandLineAPIHost.cpp:169
> -    if (m_domStorageAgent)
> -	   return m_domStorageAgent->storageId(storage);
> -    return { };
> +    return InspectorDOMStorageAgent::storageId(storage);

Nice!

>> Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:184
>> +	    errorString = "Missing page agent"_s;
> 
> This should probably be `"Missing Page agent"`.

Agreed.