[webkit-reviews] review granted: [Bug 195793] Web Inspector: DOM: "Capture Screenshot" should only be shown if the node is attached : [Attachment 365115] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195793: Web Inspector: DOM: "Capture Screenshot" should only be shown if
the node is attached
https://bugs.webkit.org/show_bug.cgi?id=195793

Attachment 365115: Patch

https://bugs.webkit.org/attachment.cgi?id=365115&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 365115
  --> https://bugs.webkit.org/attachment.cgi?id=365115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365115&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:210
> -    if (WI.domDebuggerManager.supported && isElement &&
!domNode.isPseudoElement() && domNode.ownerDocument) {
> +    if (WI.domDebuggerManager.supported &&isElement &&
!domNode.isPseudoElement() && attached) {

Style: Oops on the lost space.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:781
> +	   if (WI.cssManager.canForcePseudoClasses() &&
this.representedObject.attached) {

Might want to extract the attached into a bool hear to avoid people potentially
recomputing it later.