[webkit-reviews] review granted: [Bug 195913] Prune code after ForceOSRExit : [Attachment 365069] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 18:55:23 PDT 2019

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 195913: Prune code after ForceOSRExit

Attachment 365069: patch


--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 365069
  --> https://bugs.webkit.org/attachment.cgi?id=365069

View in context: https://bugs.webkit.org/attachment.cgi?id=365069&action=review


> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7400
> +		       node->removeWithoutChecks();

Maybe put a comment here that this is needed to make sure that we don't emit
phantoms for the results of opcodes that we are going to remove.

More information about the webkit-reviews mailing list