[webkit-reviews] review granted: [Bug 194648] [JSC] LLIntEntryPoint creates same DirectJITCode for all functions : [Attachment 364689] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 16:19:08 PDT 2019


Keith Miller <keith_miller at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 194648: [JSC] LLIntEntryPoint creates same DirectJITCode for all functions
https://bugs.webkit.org/show_bug.cgi?id=194648

Attachment 364689: Patch

https://bugs.webkit.org/attachment.cgi?id=364689&action=review




--- Comment #26 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 364689
  --> https://bugs.webkit.org/attachment.cgi?id=364689
Patch

r=me. Although, I wonder if the getters should only have a weak static
reference to some refcounted thing and we regenerate when needed. It's probably
not worth doing now though.


More information about the webkit-reviews mailing list