[webkit-reviews] review granted: [Bug 195785] Implement DownloadMonitor to prevent long-running slow downloads from background apps : [Attachment 365025] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 195785: Implement DownloadMonitor to prevent long-running slow downloads
from background apps
https://bugs.webkit.org/show_bug.cgi?id=195785

Attachment 365025: Patch

https://bugs.webkit.org/attachment.cgi?id=365025&action=review




--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 365025
  --> https://bugs.webkit.org/attachment.cgi?id=365025
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365025&action=review

r=me

> Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp:208
> +void DownloadManager::applicationDidEnterBackground()
> +{
> +    for (auto& download : m_downloads.values())
> +	   download->applicationEnteredBackground();
> +}
> +
> +void DownloadManager::applicationWillEnterForeground()
> +{
> +    for (auto& download : m_downloads.values())
> +	   download->applicationEnteredForeground();
> +}

Nit: You can resolve the small differences in these names.

applicationEnteredForeground => applicationWillEnterForeground
applicationEnteredBackground => applicationDidEnterBackground

> Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:72
> + at property (nonatomic) NSUInteger downloadMonitorSpeedMultiplier
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

Maybe put "ForDebugging" on the ends of this name and its related names, to
clarify the purpose.