[webkit-reviews] review granted: [Bug 195862] Remove the SVG property tear off objects for SVGAnimatedBoolean : [Attachment 364966] Patch for review

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 195862: Remove the SVG property tear off objects for SVGAnimatedBoolean
https://bugs.webkit.org/show_bug.cgi?id=195862

Attachment 364966: Patch for review

https://bugs.webkit.org/attachment.cgi?id=364966&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364966
  --> https://bugs.webkit.org/attachment.cgi?id=364966
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=364966&action=review

> Source/WebCore/svg/SVGAnimatorFactory.h:52
> -	       return
std::make_unique<SVGAnimatedBooleanAnimator>(animationElement, contextElement);
> +	       return nullptr;

This is legacy code that will be removed?

> Source/WebCore/svg/SVGExternalResourcesRequired.h:77
> +    Ref<SVGAnimatedBoolean> m_externalResourcesRequired;

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/externalResourcesReq
uired says that "externalResourcesRequired" is not animatable (I could not find
it in the spec). So why do we make a animated boolean for it?