[webkit-reviews] review denied: [Bug 195756] Update checks that determine if WebKit is system WebKit : [Attachment 364678] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 18 10:55:13 PDT 2019
Alexey Proskuryakov <ap at webkit.org> has denied Keith Rollin
<krollin at apple.com>'s request for review:
Bug 195756: Update checks that determine if WebKit is system WebKit
https://bugs.webkit.org/show_bug.cgi?id=195756
Attachment 364678: Patch
https://bugs.webkit.org/attachment.cgi?id=364678&action=review
--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 364678
--> https://bugs.webkit.org/attachment.cgi?id=364678
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=364678&action=review
>>> Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm:65
>>> +#endif
>>
>> Ditto, not sure why we need to check two variants.
>
> Ditto.
Discussed in person, and these cases are not the same. Will start an e-mail
thread.
More information about the webkit-reviews
mailing list