[webkit-reviews] review granted: [Bug 195636] Add new NSAttributedString API for converting HTML : [Attachment 364938] Patch 4 / 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 10:55:10 PDT 2019


Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 195636: Add new NSAttributedString API for converting HTML
https://bugs.webkit.org/show_bug.cgi?id=195636

Attachment 364938: Patch 4 / 4

https://bugs.webkit.org/attachment.cgi?id=364938&action=review




--- Comment #76 from Tim Horton <thorton at apple.com> ---
Comment on attachment 364938
  --> https://bugs.webkit.org/attachment.cgi?id=364938
Patch 4 / 4

View in context: https://bugs.webkit.org/attachment.cgi?id=364938&action=review

> Source/WebCore/en.lproj/Localizable.strings:184
> +/* WKErrorContentFailedToLoad description */

The names here don't match the implementation anymore

> Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.h:49
> + of this block type must expect to be called asynchronously when passed to
HTML methods.

"HTML methods" is a bit odd.

> Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:110
> +    static auto* cache = [[NSMutableArray alloc]
initWithCapacity:maximumWebViewCacheSize];

I have a feeling the star's on the wrong side, but auto is weird :D

> Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:123
> +	   configuration._allowsJavaScriptMarkup = NO;

🎉


More information about the webkit-reviews mailing list