[webkit-reviews] review granted: [Bug 195871] Structure::flattenDictionary() should clear unused property slots. : [Attachment 364996] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 18 07:38:46 PDT 2019
Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 195871: Structure::flattenDictionary() should clear unused property slots.
https://bugs.webkit.org/show_bug.cgi?id=195871
Attachment 364996: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=364996&action=review
--- Comment #2 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 364996
--> https://bugs.webkit.org/attachment.cgi?id=364996
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=364996&action=review
r=me after addressing ChangeLog wording.
> Source/JavaScriptCore/ChangeLog:9
> + It current attempts to do this but fails because it's actually
clearing up the
Should this read *currently* ?
> Source/JavaScriptCore/ChangeLog:10
> + preCapacity region instead. The fix i simply to account for the
preCapacity
Should this read "The fix is simply to ..."?
More information about the webkit-reviews
mailing list