[webkit-reviews] review granted: [Bug 195857] ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail: : [Attachment 364942] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 16 14:47:41 PDT 2019

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 195857: ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in

Attachment 364942: Patch


--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 364942
  --> https://bugs.webkit.org/attachment.cgi?id=364942

View in context: https://bugs.webkit.org/attachment.cgi?id=364942&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:652
> +	   [_doubleTapGestureRecognizer setGestureFailedTarget:self

Nit - Is there a reason we prefer setting the target to self instead of nil?

More information about the webkit-reviews mailing list