[webkit-reviews] review granted: [Bug 195824] [iOS] Software keyboard never appears when editing on some websites : [Attachment 364901] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 195824: [iOS] Software keyboard never appears when editing on some websites
https://bugs.webkit.org/show_bug.cgi?id=195824

Attachment 364901: Patch

https://bugs.webkit.org/attachment.cgi?id=364901&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 364901
  --> https://bugs.webkit.org/attachment.cgi?id=364901
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364901&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2821
> +    auto* oldFocusedFrame = m_page->focusController().focusedFrame();
> +    auto* oldFocusedElement = oldFocusedFrame ?
oldFocusedFrame->document()->focusedElement() : nullptr;

Please use Ref/RefPtr.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2830
> +	   auto* newFocusedFrame = m_page->focusController().focusedFrame();
> +	   auto* newFocusedElement = newFocusedFrame ?
newFocusedFrame->document()->focusedElement() : nullptr;

Ditto