[webkit-reviews] review granted: [Bug 195693] Web Inspector: HAR Extension for Resource Priority : [Attachment 364862] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195693: Web Inspector: HAR Extension for Resource Priority
https://bugs.webkit.org/show_bug.cgi?id=195693

Attachment 364862: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=364862&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364862
  --> https://bugs.webkit.org/attachment.cgi?id=364862
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364862&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:332
> +	   case WI.Resource.NetworkPriority.Low:
> +	       return "low";
> +	   case WI.Resource.NetworkPriority.Medium:
> +	       return "medium";
> +	   case WI.Resource.NetworkPriority.High:
> +	       return "high";

Could we use the `NetworkAgent.MetricsPriority` values instead, or are you
worried about backward/forward compatibility?

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:335
> +	   console.assert(false);

`console.assert()` works instead of this :P

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:380
> -	       console.warn("Unknown HAR Protocol _fetchType", fetchType);
> +	       console.warn("Unknown HAR _fetchType value", fetchType);

Oops :P

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:392
> +	   case "low":
> +	       return WI.Resource.NetworkPriority.Low;
> +	   case "medium":
> +	       return WI.Resource.NetworkPriority.Medium;
> +	   case "high":
> +	       return WI.Resource.NetworkPriority.High;

Ditto (>327).