[webkit-reviews] review granted: [Bug 195626] [iOS] No DOM keypress event emitted for cursor key commands when non-editable element is focused : [Attachment 364404] Patch and tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 195626: [iOS] No DOM keypress event emitted for cursor key commands when
non-editable element is focused
https://bugs.webkit.org/show_bug.cgi?id=195626

Attachment 364404: Patch and tests

https://bugs.webkit.org/attachment.cgi?id=364404&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 364404
  --> https://bugs.webkit.org/attachment.cgi?id=364404
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=364404&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2725
> +    // UIKit IPI do not forward to the WebView.

As we chatted about earlier, this could read a bit nicer (e.g. "These are UIKit
IPI methods, so we don't forward them to the web view.")