[webkit-reviews] review granted: [Bug 195709] Web Inspector: Timelines - Import / Export Timeline Recordings : [Attachment 364735] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 15 16:23:53 PDT 2019

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195709: Web Inspector: Timelines - Import / Export Timeline Recordings

Attachment 364735: [PATCH] Proposed Fix


--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364735
  --> https://bugs.webkit.org/attachment.cgi?id=364735
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364735&action=review


> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingImportedView.js:38
> +    get visible() { return this._visible; }

Style: this should be on separate lines, since the setter is "complex".

More information about the webkit-reviews mailing list