[webkit-reviews] review granted: [Bug 195827] Need to check ObjectPropertyCondition liveness before accessing it when firing watchpoints. : [Attachment 364857] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 195827: Need to check ObjectPropertyCondition liveness before accessing it
when firing watchpoints.
https://bugs.webkit.org/show_bug.cgi?id=195827

Attachment 364857: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=364857&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 364857
  --> https://bugs.webkit.org/attachment.cgi?id=364857
proposed patch.

I’m fine with this fix but please file a bug about how we shouldn’t have
watchpoints that fire after death and add a fixme at all isStillLive checks
that links to that bug.