[webkit-reviews] review granted: [Bug 195718] _WKDownload should conform to NSCopying protocol : [Attachment 364596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 15 15:13:24 PDT 2019

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 195718: _WKDownload should conform to NSCopying protocol

Attachment 364596: Patch


--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 364596
  --> https://bugs.webkit.org/attachment.cgi?id=364596

View in context: https://bugs.webkit.org/attachment.cgi?id=364596&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm:88
> +    return [self retain];

copy -> cancel -> cancels the original, I guess that's OK?

More information about the webkit-reviews mailing list