[webkit-reviews] review granted: [Bug 195822] Provide an option for an always-on fast click mode in iOS : [Attachment 364849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 15 14:58:32 PDT 2019


Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 195822: Provide an option for an always-on fast click mode in iOS
https://bugs.webkit.org/show_bug.cgi?id=195822

Attachment 364849: Patch

https://bugs.webkit.org/attachment.cgi?id=364849&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 364849
  --> https://bugs.webkit.org/attachment.cgi?id=364849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364849&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1507
> +	   RELEASE_LOG(ViewGestures, "Potential tap found an element and fast
taps are forced on. Trigger click. (%p)", self);

You call it a tap here, but clicks elsewhere. Which is it???


More information about the webkit-reviews mailing list